Skip to content

If the buffer has a path, pass it to buildifier as -path PATH. #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2018
Merged

If the buffer has a path, pass it to buildifier as -path PATH. #101

merged 1 commit into from
Jul 27, 2018

Conversation

@malcolmr
Copy link
Member

Fixes #100.

@malcolmr malcolmr requested a review from dbarnett July 25, 2018 12:06
xanderman
xanderman approved these changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@xanderman xanderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malcolmr malcolmr merged commit 232226e into google:master Jul 27, 2018
@malcolmr malcolmr deleted the buildifier-path branch July 27, 2018 09:23
@malcolmr malcolmr mentioned this pull request Aug 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dbarnett dbarnett dbarnett approved these changes

@xanderman xanderman xanderman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malcolmr @dbarnett @xanderman @googlebot